Skip to content

fix ICE: rustdoc: const parameter types cannot be generic #149288 #149334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 27, 2025
Merged

fix ICE: rustdoc: const parameter types cannot be generic #149288 #149334

merged 2 commits into from
Nov 27, 2025
+17 −6

Conversation

@asukaminato0721
Copy link
Contributor

@asukaminato0721 asukaminato0721 commented Nov 25, 2025 •
edited by rustbot
Loading

fix #149288

Applied the patch.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Nov 25, 2025
@fmease
Copy link
Member

fmease commented Nov 25, 2025 •
edited
Loading

Thanks! Could you please add a regression test? A UI test in tests/rustdoc-ui/ would be sufficient but an HTML test in tests/rustdoc/ would be even better! :)

@rustbot rustbot added the T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. label Nov 26, 2025
@asukaminato0721 asukaminato0721 marked this pull request as ready for review November 26, 2025 07:33
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 26, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 26, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 26, 2025

r? @notriddle

rustbot has assigned @notriddle.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@notriddle
Copy link
Contributor

notriddle commented Nov 27, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 27, 2025

📌 Commit 171c77e has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 27, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 27, 2025
Merged
bors added a commit that referenced this pull request Nov 27, 2025
@bors
Auto merge of #149387 - matthiaskrgr:rollup-hkkht91, r=matthiaskrgr
f392ed5 
Rollup of 6 pull requests

Successful merges:

 - #148256 (remove support for `typeof`)
 - #148589 (Rename `DropGuard::into_inner` to `DropGuard::dismiss`)
 - #149001 (Fix false positive of "multiple different versions of crate X in the dependency graph")
 - #149334 (fix ICE: rustdoc: const parameter types cannot be generic #149288)
 - #149345 (Deeply normalize param env in `compare_impl_item` if using the next solver)
 - #149367 (Tidying up UI tests [4/N])

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9320a7d into rust-lang:main Nov 27, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 27, 2025
rust-timer added a commit that referenced this pull request Nov 27, 2025
@rust-timer
Unrolled build for #149334
a86be95 
Rollup merge of #149334 - asukaminato0721:149288, r=notriddle

fix ICE: rustdoc: const parameter types cannot be generic #149288

fix #149288

Applied the patch.
@asukaminato0721 asukaminato0721 deleted the 149288 branch November 27, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@notriddle notriddle

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

ICE: rustdoc: const parameter types cannot be generic

5 participants

@asukaminato0721 @fmease @rustbot @notriddle @bors